Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check markdown in travis build #151

Merged
merged 6 commits into from
Apr 22, 2018
Merged

check markdown in travis build #151

merged 6 commits into from
Apr 22, 2018

Conversation

thijstriemstra
Copy link
Contributor

No description provided.

@thijstriemstra
Copy link
Contributor Author

@FooDeas the default base branch is master when you open a pull request, I think that should change to devel because I now have to change it manually.

@FooDeas
Copy link
Owner

FooDeas commented Apr 4, 2018

Default branch is changed to devel.

@thijstriemstra
Copy link
Contributor Author

thijstriemstra commented Apr 4, 2018

Do we really need the exclusions of shellcheck and markdown rules?

Think so @FooDeas, try running them without (line-length then has to be < 80 triggering many errors for example and I found other errors not useful). The ~ means they're excluded for mdl.

@FooDeas
Copy link
Owner

FooDeas commented Apr 7, 2018

I see! Then I suggest the following .travis.yml config:

language: bash
install: gem install mdl
script:
 - bash -c 'shopt -s globstar; shellcheck **/*.sh'
 - mdl -r '~MD013, ~MD036' .

I'd like to fix the docs for MD013 and MD036 piece by piece.

@thijstriemstra
Copy link
Contributor Author

@FooDeas changed it but expecting the build to fail now. Feel free to fix these in this branch or elsewhere.

@FooDeas FooDeas force-pushed the check-md branch 3 times, most recently from a671bcd to b62b116 Compare April 22, 2018 20:07
@FooDeas FooDeas merged commit fc962a6 into devel Apr 22, 2018
@FooDeas FooDeas deleted the check-md branch April 22, 2018 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants