This repository has been archived by the owner on Dec 31, 2023. It is now read-only.
Fix tests by “pinning” Anki dependencies via a time machine #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Packages anki and aqt do not pin their requirements,
which breaks anki <= 2.1.49 because of protobuf major version bump.
While it's possible to use requirements.txt as constraints,
it might not be the best idea:
* requirements.txt can’t be used as constraints
without some careful sed’ding to remove hashes and extras;
* its location changes between versions;
* you can’t get this file for a pre-release version of Anki
since these don't get git tags;
* it’s rarely updated anyway and hence won’t reliably
produce the environment that actual Anki uses.
So use a pypi-timemachine, which prevents pip from using packages
that were uploaded after a specified date.
While the code is a tad complex, it feels slightly less hacky,
and is likely to be producing more accurate environments.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements some of the changes I mentioned in #327. The other changes are more optional; the changes here are rather “core”. This also adds running tests in parallel and the new versions of Anki. The tests do pass!
