Skip to content
This repository has been archived by the owner on Dec 1, 2017. It is now read-only.

Generic comic path #57

Open
ghost opened this issue Feb 28, 2016 · 6 comments
Open

Generic comic path #57

ghost opened this issue Feb 28, 2016 · 6 comments

Comments

@ghost
Copy link

ghost commented Feb 28, 2016

I have an issue - when I add new comic, system automatically processes its name into path. However, it's not always good, because some comics have very elaborated names, including some special symbols or just written in non-latinic alphabet, which are all changed into _ in the process. Could you, please, add optional field for generic path?
Currently I have to manually change database and folder to correct that.
For example: "Старый падуб" (based on pun) for name, visible to audience, will change into ___ for system, but it must be "old_holly".

@pushrbx
Copy link
Contributor

pushrbx commented Mar 13, 2016

Do you mean the slug in the URL? That can be done very quickly.

@ghost
Copy link
Author

ghost commented Mar 20, 2016

Slug?
Well, yes, that thing, translating project name into URL.

@pushrbx
Copy link
Contributor

pushrbx commented Mar 20, 2016

I've already started working on a fix.
I'll will add a checkbox and a field which will let you specify a custom slug. If you don't specify a slug it will translate the foreign letters to Latin letters instead of replacing them with ''.

@ghost
Copy link
Author

ghost commented Mar 20, 2016

Cool.
Could you please tell, which files are to be replaced? I've adjusted default reader design a little bit, don't want to lose it due to update.

@pushrbx
Copy link
Contributor

pushrbx commented Mar 20, 2016

My fix won't affect the theme I think, unless you added extra functionality without merging it here.
For now it looks like this, but this is not the final working version of my fix:
pushrbx@1fe2127

@pushrbx
Copy link
Contributor

pushrbx commented Mar 20, 2016

#59 added

oohnoitz added a commit that referenced this issue Apr 17, 2016
Fixed issue #57 - Added support for non-latin letters in the comic's name.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant