Add methods to get a system temp dir, create temp file and folder #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ForNeVeR
requested changes
Jul 21, 2024
TruePath/Temporary.cs
Outdated
Comment on lines
19
to
40
| var tempPath = Path.GetTempPath(); | ||
| return new AbsolutePath(tempPath); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Creates a temporary file. | ||
| /// </summary> | ||
| /// <returns>An AbsolutePath representing the newly created temporary file.</returns> | ||
| public static AbsolutePath CreateTempFile() | ||
| { | ||
| var tempPath = Path.GetTempFileName(); | ||
| return new AbsolutePath(tempPath); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Creates a temporary folder with the specified prefix. | ||
| /// </summary> | ||
| /// <param name="prefix">An optional string to add to the beginning of the subdirectory name.</param> | ||
| /// <returns>An AbsolutePath representing newly created temporary folder</returns> | ||
| public static AbsolutePath CreateTempFolder(string? prefix = null) | ||
| { | ||
| var tempDirectoryInfo = Directory.CreateTempSubdirectory(prefix); |
There was a problem hiding this comment.
Theoretically, any of these calls might return a relative path, so I'd suggest using AbsolutePath.CurrentWorkingDirectory / tempPath in all three cases.
ForNeVeR
force-pushed
the
76-temp-directory-methods
branch
from
b32239f
to
feea9ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #76