Update acorn to ^3.1.0 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, the ES5 fallback in `reallyParse` is now unnecessary because the bug is now fixed in acorn. Second, a bug-fix in the AST walker made the walker now go through CatchClause as well, changing the number of parents before the `param` property while making it possible to attach the locals on the entire CatchClause, which is a cleaner solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, the ES5 fallback in
reallyParseis now unnecessary because the bug is now fixed in acorn, although a major bump is required since ES6 and ES5 are not fully compatible.Second, a bug-fix in the AST walker made the walker now go through CatchClause as well, changing the number of parents before the
paramproperty while making it possible to attach the locals on the entire CatchClause, which is a cleaner solution.