-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several macOS new artifacts #294
Several macOS new artifacts #294
Conversation
Codecov Report
@@ Coverage Diff @@
## master #294 +/- ##
=======================================
Coverage 91.08% 91.08%
=======================================
Files 7 7
Lines 415 415
=======================================
Hits 378 378
Misses 37 37 Continue to review full report at Codecov.
|
data/macos.yaml
Outdated
- type: FILE | ||
attributes: | ||
paths: | ||
- '/var/db/diagnostics/Persist/logdata.Persistent.YYYYMMDD THHMMSS.tracev3' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume YYYYMMDD THHMMSS
should be a wild card? also is the space in the string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, I will change "YYYYMMDD THHMMSS" with "*".
The space was a typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Know that "YYYYMMDDTHHMMSS" will result in an exact string match
not a glob "[0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9]T[0-9][0-9][0-9][0-9][0-9][0-9]"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in my comments on the PR #298 , I'm referring specifically to the log files *.tracev3 and the resource files under uuidtext folder (this leaves out the log statistics file for example, which are in the same folder). would you prefer to keep them anyway?
@@ -369,7 +401,7 @@ name: MacOSMailAccounts | |||
doc: Mail Accounts | |||
sources: | |||
- type: FILE | |||
attributes: {paths: ['%%users.homedir%%/Library/Mail/V2/MailData/Accounts.plist']} | |||
attributes: {paths: ['%%users.homedir%%/Library/Mail/V[0-9]/MailData/Accounts.plist']} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we seen all 0-9 versions? or is this 1-3 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have seen V2, V3 and V5, I thought 0-9 was good to be on the safe side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack, SG; maybe add this to the doc string that V2, V3 and V5 have been observed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
data/macos.yaml
Outdated
@@ -600,6 +658,14 @@ urls: | |||
- 'http://forensicswiki.org/wiki/Mac_OS_X' | |||
- 'http://forensicswiki.org/wiki/Mac_OS_X_10.9_-_Artifacts_Location#Skype' | |||
--- | |||
name: MacOSSkypeMainDirectory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing this is a cross platform application I opt to move this to applications definitions file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I will remove it. Given that there were already Skype related artifacts I just added some new ones. I will start an im application specific yaml file with those in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
data/macos.yaml
Outdated
attributes: {paths: ['%%users.homedir%%/Library/Application Support/Skype/*']} | ||
labels: [Users, Software, IM] | ||
supported_os: [Darwin] | ||
--- | ||
name: MacOSSkypePreferences |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one likely as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed (see above)
data/macos.yaml
Outdated
labels: [Users, Logs] | ||
supported_os: [Darwin] | ||
--- | ||
name: MacOSPasswordHashes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this contain broader account information?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, it has other general account info like home directory, default shells, home dir path, original full user name, user profile picture, etc. Shall we use one of the following
- name: MacOSUsersAccountsAndPassowrd
or - name: MacOSUsersAccountsAndPassowords
or just - name: MacOSUsersAccounts
with the "doc" being:
doc: Users Accounts Information and hashed Password plist files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this was already in the macos.yaml file as "MacOSUserPasswordHashesPlistFiles" same artifacts. I will remove it from this PR and address it in the next one, when cleaning the "plistfile" names
@@ -292,6 +313,17 @@ urls: | |||
- 'http://forensicswiki.org/wiki/Mac_OS_X' | |||
- 'http://forensicswiki.org/wiki/Mac_OS_X_10.9_-_Artifacts_Location#Kernel_Extension' | |||
--- | |||
name: MacOSKnowledgeC | |||
doc: KnowledgeC User and Application usage database |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
KnowledgeC ? what does this stand for?
Maybe add some urls:
https://www.mac4n6.com/blog/2018/8/5/knowledge-is-power-using-the-knowledgecdb-database-on-macos-and-ios-to-determine-precise-user-and-application-usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That DB is known as the "knowledgeC DB" that is why I left it as main name. Given it contains the user application usage, we may change it to either:
- "MacOSKnowledgeUserApplicationUsage", although it sounds too long
- just "MacOSUserApplicationUsage", better although I would have liked to keep the KnowledgeC in the name, But probably this is more useful.
About the URL, yes it is in the URLs note of the mac4n6 artifacts spreadsheet, but I just didn't parse that field in the conversion. I will add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, proper official name is "Duet Knowledge Base", changing the name to reflect this and moved "knowledgeC" and description to "doc:"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx SG
data/macos.yaml
Outdated
@@ -518,6 +550,26 @@ sources: | |||
labels: [System] | |||
supported_os: [Darwin] | |||
--- | |||
name: MacOSNotificationCenter | |||
doc: macOS NotificationCenter database |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of macOS
I opt to use the more generic MacOS
, unless it is specific to versions of MacOS that are named macOS
;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, it was a typo.
@pstirparo if ready for re-review, please re-assign me as reviewer or add a comment with PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of remaining nits and questions, but overall changes are good, thx for adding these
data/macos.yaml
Outdated
paths: | ||
- '/var/db/diagnostics/*.tracev3' | ||
- '/var/db/diagnostics/*/*.tracev3' | ||
- '/var/db/uuidtext/*' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/var/db/uuidtext/*
will only get you the files in /var/db/uuidtext/
you likely want /var/db/uuidtext/*/*
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sorry it was a typo. First level is only directories.
@@ -292,6 +313,17 @@ urls: | |||
- 'http://forensicswiki.org/wiki/Mac_OS_X' | |||
- 'http://forensicswiki.org/wiki/Mac_OS_X_10.9_-_Artifacts_Location#Kernel_Extension' | |||
--- | |||
name: MacOSKnowledgeC | |||
doc: KnowledgeC User and Application usage database |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx SG
data/macos.yaml
Outdated
labels: [Users, Logs] | ||
supported_os: [Darwin] | ||
urls: | ||
- 'https://www.mac4n6.com/blog/2018/8/5/knowledge-is-power-using-the-knowledgecdb-database-on-macos-and-ios-to-determine-precise-user-and-application-usage' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seeing this is a single url please change to urls: ['https://...']
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@@ -369,7 +401,7 @@ name: MacOSMailAccounts | |||
doc: Mail Accounts | |||
sources: | |||
- type: FILE | |||
attributes: {paths: ['%%users.homedir%%/Library/Mail/V2/MailData/Accounts.plist']} | |||
attributes: {paths: ['%%users.homedir%%/Library/Mail/V[0-9]/MailData/Accounts.plist']} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack, SG; maybe add this to the doc string that V2, V3 and V5 have been observed?
data/macos.yaml
Outdated
@@ -11,6 +11,21 @@ urls: | |||
- 'http://forensicswiki.org/wiki/Mac_OS_X' | |||
- 'http://forensicswiki.org/wiki/Mac_OS_X_10.9_-_Artifacts_Location#System_Logs' | |||
--- | |||
name: MacOSAppleUnifiedLog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please rename to "MacOSUnifiedLogging", since this is the name Apple is using.
https://developer.apple.com/videos/play/wwdc2016/721/
https://developer.apple.com/documentation/os/logging?language=occ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
data/macos.yaml
Outdated
@@ -11,6 +11,21 @@ urls: | |||
- 'http://forensicswiki.org/wiki/Mac_OS_X' | |||
- 'http://forensicswiki.org/wiki/Mac_OS_X_10.9_-_Artifacts_Location#System_Logs' | |||
--- | |||
name: MacOSAppleUnifiedLog | |||
doc: Apple Unified Log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unified Log => Unified Logging / Unified Logging and Activity Tracing / Unified Logging and Tracing System
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to "Apple Unified Logging and Activity Tracing"
data/macos.yaml
Outdated
@@ -380,7 +416,7 @@ name: MacOSMailBackupTOC | |||
doc: Mail BackupTOC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is not part of your changes but could you update this to "Mail Backup Table of Contents (TOC)", thx in advance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added several new artifacts and corrected the path of the one related to Apple Mail application (new versions can have the path different from "V2", but still always V followed by one digit --> "V[0-9]")