Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: identify primary key fields as such #409

Merged
merged 4 commits into from
Sep 10, 2020
Merged

improvement: identify primary key fields as such #409

merged 4 commits into from
Sep 10, 2020

Conversation

ghusse
Copy link
Contributor

@ghusse ghusse commented Sep 3, 2020

Linked to CU-48py0a

The property isPrimaryKey is a new one, that will be used on the server-side and on the frontend, to improve the handling of this special kind of fields.

Pull Request checklist:

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Create automatic tests
  • Test manually the implemented changes
  • Review my own code (indentation, syntax, style, simplicity, readability)
  • Wonder if you can improve the existing code

@ghusse ghusse self-assigned this Sep 3, 2020
@arnaudbesnier
Copy link
Member

Task linked: CU-48py0a Lumber - ID fields with no default value are missing

@ghusse ghusse marked this pull request as draft September 3, 2020 14:45
@ghusse ghusse assigned arnaudbesnier and unassigned ghusse Sep 4, 2020
@ghusse ghusse marked this pull request as ready for review September 4, 2020 14:33
arnaudbesnier
arnaudbesnier approved these changes Sep 7, 2020
View reviewed changes
Copy link
Member

@arnaudbesnier arnaudbesnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@arnaudbesnier arnaudbesnier assigned ghusse and unassigned arnaudbesnier Sep 7, 2020
@ghusse ghusse assigned arnaudbesnier and unassigned ghusse Sep 8, 2020
arnaudbesnier
arnaudbesnier reviewed Sep 9, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
arnaudbesnier
arnaudbesnier reviewed Sep 9, 2020
View reviewed changes
Copy link
Member

@arnaudbesnier arnaudbesnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments about unexpected changes in the Pull Request.

CHANGELOG.md Outdated Show resolved Hide resolved
@arnaudbesnier arnaudbesnier assigned ghusse and unassigned arnaudbesnier Sep 9, 2020
@ghusse ghusse force-pushed the improvement/identify-primary-key-fields branch from 6e86247 to c766dc2 Compare September 10, 2020 07:28
@ghusse ghusse merged commit 89af024 into master Sep 10, 2020
@ghusse ghusse deleted the improvement/identify-primary-key-fields branch September 10, 2020 07:30
@forest-bot
Copy link
Member

🎉 This PR is included in version 6.3.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudbesnier arnaudbesnier arnaudbesnier approved these changes

Assignees

@ghusse ghusse

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghusse @arnaudbesnier @forest-bot