Filters - Support OR filter type with conditions on belongsTo/hasOne fields #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/hasOne associations.
SteveBunlon
requested review from
VincentMolinie and
larcin
and removed request for
arnaudbesnier
larcin
suggested changes
Jun 24, 2019
SteveBunlon
force-pushed
the
add_or_filter_type_handler
branch
from
3c744ed
to
f3512d9
Compare
larcin
suggested changes
Jun 26, 2019
| if @params[:filter] | ||
| operator = " #{@params[:filterType]} ".upcase |
There was a problem hiding this comment.
[Unused Variable] - Defined but never used (doesn't seems to be needed)
| @params[:filter].each do |field, values| | ||
| next unless belongs_to_association?(field) | ||
|
|
||
| values.split(',').each do |value| | ||
| @records = belongs_to_subfield_filter(field, value) | ||
| conditions << OperatorValueParser.get_has_one_condition(@resource, field, value, @params[:timezone]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add little code to handle 'or' filter type when performing the search.
https://trello.com/c/Yv2J5C8k/3478-filters-support-or-filter-type-with-conditions-on-belongsto-hasone-fields