Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.8 update checklist #1141

Closed
yuuka-miya opened this issue Nov 26, 2014 · 29 comments

Comments

@yuuka-miya
Copy link
Member

commented Nov 26, 2014

Do we want to do this now? I'd prefer having a stable 1.7.10 release first though, but then again I like to be on the cutting edge...

Will just leave this checklist here first so we know what to do. Will be updated when more info on 1.8 comes out.

1.7 -> 1.8

  • All FML imports moved to net.minecraftforge
  • Typical MC architecture changes (only those which affect us has been posted):
    • Almost all int x, int y, int z parameters have been changed to BlockPos class
    • ForgeDirection has been removed, replaced by net.minecraft.util.EnumFacing.
    • Metadata has been extracted out in Minecraft to IBlockState, which holds a list of properties instead of magic number metadata. DO NOT listen to the fearmongering, you can do EVERYTHING with block states you could previously with metadata.
  • Update mixins (#1619)
    • EntityPlayer_01
    • BlockPortal_01
    • NetHandlerPlayServer_01 (needs updating Forge extensions)
    • NetHandlerPlayServer_02
    • CommandHandler_01
    • EntityTracker_01
    • Entity_01
    • ItemInWorldManager_01
  • Modify our worldborder to be compatible with MC's
  • Settle sponge things #1031
  • Remove our commands that vanilla adds (doas)

1.8 -> 1.8.9

  • Port to 1.8.9
  • Update to FG2
  • Java 8 compatibility
@Malkierian

This comment has been minimized.

Copy link
Member

commented Nov 26, 2014

I also would prefer to have a stable 1.7.10 version before moving on.

@yuuka-miya yuuka-miya added the onhold label Dec 1, 2014
@TheBeege

This comment has been minimized.

Copy link

commented Mar 17, 2015

@luacs1998 Are folks interested in resuming this? The server that I work with needs to upgrade to 1.8 to support the primary mod we're using, but it also relies on ForgeEssentials. I'm willing to contribute, but I'm curious as to the larger community's stance on this. I'll probably end up bugging you guys in IRC.

@olee

This comment has been minimized.

Copy link
Member

commented Mar 17, 2015

1.8 update is planned for April if everything goes fine.
Currently I'm very busy, but in a week I will have time again and will try to finish all that's left for 1.7.10 so we can move on to 1.8.

@longlostbro

This comment has been minimized.

Copy link

commented May 23, 2015

Is there an update on this estimated date?

@olee

This comment has been minimized.

Copy link
Member

commented May 24, 2015

We still need a bit more time to get out of beta for 1.7.10.
If we update too early, we will not be able to support both 1.7.10 and 1.8 at the same time.
Currently I am rewriting a lot of old code to get FE ready for an easy update process and then be able to maintain both 1.7.10 and 1.8 at the same.

TL;DR:
Wait one or two weeks and see if we can get a non-beta release out.
After that we will (probably) start updating.

@yuuka-miya

This comment has been minimized.

Copy link
Member Author

commented May 25, 2015

Very likely we may be doing parallel releases for 1.7.10 and 1.8.

I'll put olee in charge of the 1.7.10 releases, and do the 1.8 update myself.

We'll need to configure jenkins to build multiple branches though.

@liach

This comment has been minimized.

Copy link
Contributor

commented May 25, 2015

Nice!!!!!!

@olee

This comment has been minimized.

Copy link
Member

commented May 25, 2015

TL;DR: I code and @luacs1998 merges changes to 1.8? 😄

@yuuka-miya

This comment has been minimized.

Copy link
Member Author

commented May 25, 2015

Yes, but I would still prefer it if you discussed major and not-so-major stuff with me first.

And of course, Mojang has to decide when they want to start cracking on 1.9 and Lex has to decide when he wants to update. Naturally FE 1.7.10 should go stable before we do anything related to 1.8.x.

@olee olee referenced this issue May 25, 2015
11 of 11 tasks complete
@yuuka-miya yuuka-miya modified the milestone: 1.4.2_1.8 Jun 10, 2015
@liach

This comment has been minimized.

Copy link
Contributor

commented Jul 13, 2015

So will there be a branch for 1.8 now, as 1.4.0 is released?

@olee

This comment has been minimized.

Copy link
Member

commented Jul 13, 2015

Yeah probably - though I don't have much time right now, I will help out with as well whenever I have time.

@olee

This comment has been minimized.

Copy link
Member

commented Jul 21, 2015

Got working 1.8 branch now - closing.

@olee olee closed this Jul 21, 2015
@yuuka-miya

This comment has been minimized.

Copy link
Member Author

commented Jul 21, 2015

Working doesn't mean checklist is complete.

@yuuka-miya yuuka-miya reopened this Jul 21, 2015
@yuuka-miya

This comment has been minimized.

Copy link
Member Author

commented Jul 21, 2015

Also, the separate job for 1.8 builds should be rolled into the main job when we decide to shift all development efforts to 1.8.

@yuuka-miya yuuka-miya added in-progress and removed onhold labels Jul 21, 2015
@olee

This comment has been minimized.

Copy link
Member

commented Jul 21, 2015

Well 1.7.10 is kinda a LTS version so this will probably take at least half a year before we can consider removing that job.

@yuuka-miya

This comment has been minimized.

Copy link
Member Author

commented Jul 21, 2015

1.6.4 was also LTS too until recently and Jenkins only built 1.7 jobs.

If there's a need to make emergency bugfix releases after the switch we can always build manually.

@olee

This comment has been minimized.

Copy link
Member

commented Jul 21, 2015

Though keeping the job active makes these things easier.

@yuuka-miya

This comment has been minimized.

Copy link
Member Author

commented Jul 21, 2015

Then it gets hived off.

@yuuka-miya

This comment has been minimized.

Copy link
Member Author

commented Jan 12, 2016

I'll probably work on the 1.8.9 port one of these days.

What this means is that the 1.8.0 versions will no longer be supported, and our supported 1.8.x version will go up to 1.8.9.

Expect to see a final 1.8.0 build on CurseForge soon.

@olee - this will also be a test of how version-proof your patcher is :D

@liach

This comment has been minimized.

Copy link
Contributor

commented Jan 12, 2016

When will Fe support java8 only?

@yuuka-miya

This comment has been minimized.

Copy link
Member Author

commented Jan 12, 2016

My plan is 1.8.9 update.

But plans can and do change.

@P3rf3ctXZer0

This comment has been minimized.

Copy link

commented Jan 12, 2016

1.8.9 has a massive performance increase! What used to take minutes to load a 32 size of chunks now takes about 10 secs. from 1.7.10 that is a 10000% increase in performance. Even loading new chunks does not drag my fps down I still remain at 57 - 62

@olee

This comment has been minimized.

Copy link
Member

commented Jan 12, 2016

1.8 in general already has that performance boost

@P3rf3ctXZer0

This comment has been minimized.

Copy link

commented Jan 12, 2016

Not really 1.8 I can actually see it for myself 1.8.9 has more than 1.8. You could always go see the change log for yourself : D The big thing is proper threading along with about a few major tweaks that fastcraft provided for 1.7.10 the difference is now that stuff is built in along with tweaks that are not even seen. All I know is I can legit see a performance increase that 1.8 did not fully have. Take that for what it is worth. Aside from that I will be donating more just not this second cause I am moving in 3 days.

@yuuka-miya

This comment has been minimized.

Copy link
Member Author

commented Jan 13, 2016

Well, most of the mods are skipping 1.8.0 and going up to 1.8.9 - I don't see why we should stay.

I'll do the port this weekend if time allows,

@P3rf3ctXZer0

This comment has been minimized.

Copy link

commented Jan 13, 2016

Thank you <3

@yuuka-miya

This comment has been minimized.

Copy link
Member Author

commented Feb 8, 2016

@olee since I haven't be able to catch you on IRC:

Since the only broken parts of the 1.8.9 port are on the clientside mod, do you want to push server builds of FE 1.8.9 for people to use first? Then we can worry about fixing the client later.

@seanamor

This comment has been minimized.

Copy link

commented Feb 15, 2016

Absolutely dying to see 1.8.9 in action, after all its "essential" :P to minecraft! Cheer on all your hard work! my latest SpongeForge server will do well with such a masterpiece, not sure essentialcmds will suffice, lacking worldguard/perm support.

@yuuka-miya

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2016

@yuuka-miya yuuka-miya closed this Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants
You can’t perform that action at this time.