Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Valid accessibility live region #20

Merged
merged 3 commits into from
Jul 10, 2018
Merged

Feature: Valid accessibility live region #20

merged 3 commits into from
Jul 10, 2018

Conversation

alex-saunders
Copy link
Contributor

Adds rule to ensure accessibilityLiveRegion prop values are one of the following:

  • none
  • polite
  • assertive

screen shot 2018-07-10 at 11 17 41

closes #18

jevakallio
jevakallio approved these changes Jul 10, 2018
View reviewed changes
Copy link
Contributor

@jevakallio jevakallio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@jevakallio jevakallio merged commit 677f4b4 into master Jul 10, 2018
@jevakallio jevakallio deleted the feature/valid-accessibility-live-region branch July 10, 2018 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jevakallio jevakallio jevakallio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify that accessibilityLiveRegion values are valid
2 participants
@alex-saunders @jevakallio