Mobile section #47
Mobile section #47
Conversation
|
Great start! Just a few comments so far. I'll let @kenwheeler comment more as to substance. Oh, and make sure to follow https://github.com/FormidableLabs/formidable-playbook/blob/master/CONTRIBUTING.md before final submission for review to pass CI. |
|
I have a few sample chapters up (indicated in the PR description ☝️) for review. I have tendency towards verbosity, would appreciate notes on:
Ryan, your previous comment mentioned you have "a few comments" but I can not see them. Were they perhaps written in review mode and review not concluded? |
There was a problem hiding this comment.
Ryan, your previous comment mentioned you have "a few comments" but I can not see them. Were they perhaps written in review mode and review not concluded?
Ugh. The new "integrated review" feature had all of my comments as pending...
style - is this appropriate for the playbook or should I refocus
The existing playbook is more like one-off, very specific "recipes" for scenarios (like "tree shaking" or "code splitting" or "source maps" or "mono repo vs. multi repo"). This is mostly because I have very specific patterns / "problem / solution" things to get up because we end up repeating them everywhere.
This is more of an introduction and narrative walkthrough, which I'd say that longer term is perhaps more useful for the playbook to be. So as long as @kenwheeler 's on board for content and terseness, I'm on board for the more overarching tutorial nature of the mobile meta section!
| Options: | ||
| * Bitrise.io, | ||
| * Jenkins + Private Build Server, | ||
| * Microsoft VSTS + MacInCloud build agents) |
docs/mobile/deployments.md
Outdated
| * Bitrise.io, | ||
| * Jenkins + Private Build Server, | ||
| * Microsoft VSTS + MacInCloud build agents) | ||
|
|
There was a problem hiding this comment.
Are things like Travis / CircleCI also available?
There was a problem hiding this comment.
Travis and CircleCI are options, but the pricing for Mac build servers are somewhat overpriced. CircleCI is $249/mo for the minimum plan. Travis used to have a price listed but they have now removed it from public pricing page, would need to ask.
I feel in the hosted mobile CI startup space Bitrise is a clear winner, because their workflows are very much optimised for common mobile app build tasks. Though any machine with ssh access and ability to run Jenkins and Fastlane will do in practice.
| @@ -0,0 +1,15 @@ | |||
| ## Mobile Playbook: Platform-specific code | |||
|
|
|||
| #### Prefer to separate `*.ios.js` and `*.android.js` component files over switching on `Platform.*` | |||
There was a problem hiding this comment.
NIT: Make sure this section ends up in agreement with our eslint-config-formidable various discussions.
There was a problem hiding this comment.
Sure thing, although this naming convention is NOT optional and up for discussion. It's imposed by the build chain.
There was a problem hiding this comment.
Sure. Then in this case, the configurations/es6-react-native.js should reflect the mandatory conventions differently than the rest of our files.
|
|
||
| #### Support token invalidation | ||
|
|
||
| #### Using social authentication providers (OAuth, OpenID) |
There was a problem hiding this comment.
Maybe add a section on how to integrate with on device switch to app auth, w/ react native libs
docs/mobile/debugging.md
Outdated
| #### react-native log-{platform} | ||
|
|
||
| #### redux-remote-devtools | ||
|
|
| ## Mobile Playbook: Navigation and routing | ||
|
|
||
| #### Use NavigationExperimental | ||
|
|
There was a problem hiding this comment.
True - there's also ex-navigation now, which looks like it might be the new ex-navigator for NavigationExperimental
docs/mobile/state-management.md
Outdated
|
|
||
| #### Prepare for store schema migrations/pruning on updates | ||
|
|
||
| #### Using GraphQL with Redux vs Relay |
There was a problem hiding this comment.
I don't have enough experience to speak to MobX. I'd love a paragraph on it if you have time to write one. Feel free to drop a commit into #48
|
This structure looks great. A couple things I might add for consideration for the final product:
|
|
I can add some content to the deployment page with respect to different certificate types, provisioning and entitlements. Perhaps another section on extensions would be useful, like Siri integration, WatchKit apps, Home/Lock screen widgets and how they're done and configured using App Groups and they have their own provisioning as well. |
Mobile playbook: Networking
Mobile playbook: State management chapter
Mobile section: UI and UX
Mobile playbook: Debugging chapter
…entProcess Add content for mobile Apple deployment processes.
WORK IN PROGRESS
Main branch for mobile development playbook. Plan is to create sub-section branches off the main feature branch to discuss and review particulars.
Discussion for playbook structure, the index document, and future chapter contents is welcome here. Detailed chapter contents to be discussed in section branches as they are started.