Issue 622: Slides that are not fully visible cannot receive focus. #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not receive focus
mariano-formidable
force-pushed
the
fix/622-tabindex
branch
from
0555bd8
to
9b43486
Compare
| } = config; | ||
|
|
||
| // Slide width can't be 0 | ||
| const fullSlideWidth = slideWidth + cellSpacing || 1; |
There was a problem hiding this comment.
Added this so tests would pass because most of our tests don't actually set a slideWidth (because the virtual dom doesn't have one).
| @@ -169,3 +170,44 @@ export const handleSelfFocus = e => { | |||
| e.currentTarget.focus(); | |||
| } | |||
| }; | |||
|
|
|||
| export const isFullyVisible = (slideIndex, config) => { | |||
There was a problem hiding this comment.
I also removed positionValue from the passed in arguments since I realized I wasn't even using it 😱
sarmeyer
approved these changes
Jan 21, 2020
|
Will this be in a release of it is usable as soon as you merge on master? I have Updated to 4.6.1 and I still can tab passed the visible slides and the it still pushes the right control to the middle of the view like in #622 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the same as this PR (#642), it's just that the merge target is master.
Fixes #622