This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
Bug: Make Children.only check handle string children #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed lint. Hanging my head in shame. |
Closed
alexlande
force-pushed
the
bug-onlyChildIsString
branch
from
b56039e
to
5eaa598
Compare
alexlande
force-pushed
the
bug-onlyChildIsString
branch
from
5eaa598
to
dc6ceff
Compare
alexlande
added a commit
that referenced
this pull request
May 13, 2015
Bug: Make Children.only check handle string children
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is embarrassing. I pulled + ran the tests on #140 but didn't run the examples. If I did, I would have noticed that it broke when the old child of a component is a string, not an element. This adds a check + a test for that case.
/cc @ianobermiller