Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

Release v0.12.0 #155

Merged
merged 3 commits into from
May 16, 2015
Merged

Release v0.12.0 #155

merged 3 commits into from
May 16, 2015

Conversation

ianobermiller
Copy link
Contributor

closes #141
closes #145

@@ -5,7 +5,7 @@ var getState = require('./get-state');
var prefix = require('./prefix');

var ExecutionEnvironment = require('exenv');
var React = require('react/addons');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad! This was causing us to suck react into the dist build!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 89ff58b on v0.12 into 823b6fd on master.

@awkaiser
Copy link

@ianobermiller the package.json should have "main": "modules/index.js" instead of "main": "lib/index.js"

@awkaiser
Copy link

Ah, I see, the Babel transpiled modules end up in lib via npm run lib. Nevermind. :)

Giving this a whirl...

@awkaiser
Copy link

@ianobermiller & @alexlande: As supported by @doctyper, why not use NPM prepublish + .npmignore? IMHO, NPM packages should be immediately usable via the entry script given set as main in package.json.

@doctyper
Copy link
Contributor

Agreed, it would be great if you could get that and the rimraf change in 0.12.

@ianobermiller
Copy link
Contributor Author

@awkaiser I thought that was what we were doing, I guess not! Yes, I think prepublish is the way to go.

@doctyper we'll get rimraf in as well.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 35d88bc on v0.12 into 823b6fd on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 22bfb28 on v0.12 into 823b6fd on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling de23ee8 on v0.12 into 823b6fd on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 788b2e5 on v0.12 into 823b6fd on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 87b8aeb on v0.12 into 823b6fd on master.

ianobermiller added a commit that referenced this pull request May 16, 2015
@ianobermiller ianobermiller merged commit 54af2e4 into master May 16, 2015
@ianobermiller ianobermiller deleted the v0.12 branch May 19, 2015 12:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Where is Radium.getState? Release 0.12
4 participants