This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -5,7 +5,7 @@ var getState = require('./get-state'); | |||
var prefix = require('./prefix'); | |||
|
|||
var ExecutionEnvironment = require('exenv'); | |||
var React = require('react/addons'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad! This was causing us to suck react into the dist build!
@ianobermiller |
Ah, I see, the Babel transpiled modules end up in Giving this a whirl... |
@ianobermiller & @alexlande: As supported by @doctyper, why not use NPM prepublish + .npmignore? IMHO, NPM packages should be immediately usable via the entry script given set as |
Agreed, it would be great if you could get that and the |
35d88bc
to
09e76d5
Compare
f8fac0f
to
87b8aeb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #141
closes #145