Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

Warn when mixing longhand and shorthand props #218

Merged
merged 1 commit into from
Jun 22, 2015

Conversation

ianobermiller
Copy link
Contributor

Fixes #95

@alexlande
Copy link
Contributor

Nice, looks good. You've got a little lint though.

ianobermiller added a commit that referenced this pull request Jun 22, 2015
Warn when mixing longhand and shorthand props
@ianobermiller ianobermiller merged commit dc94b21 into master Jun 22, 2015
@ianobermiller ianobermiller deleted the longhand-warning branch June 25, 2015 05:36
@williamboman
Copy link
Contributor

Quite annoying to see these warnings when it's done deliberately, e.g.;

// utils.radium.js
export const resetBoxModel = { margin: 0, padding: 0, border: 0 };

// foo.jsx
import {resetBoxModel} from './utils.radium';

const styles = {
    base: {
        ...resetBoxModel,
        marginRight: 5,
        paddingLeft: 10,
    }
};

or are there better ways of doing this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants