This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
ensuring that defaultProps get transferred in every browser #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't we need to do the same for |
|
@ianobermiller good thinking, that's done too |
|
Can you just add a comment why we are doing this? Just say this is for IE <10 and link to the babel caveats page. Then this should be good to go. Thanks again! |
|
@ianobermiller done! |
|
Nice work, thanks @bobbyrenwick! |
ianobermiller
added a commit
that referenced
this pull request
Jul 7, 2015
ensuring that defaultProps get transferred in every browser
AnSavvides
pushed a commit
to AnSavvides/radium
that referenced
this pull request
Aug 11, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #235, and doesn't require a move away from using the subclass method in order to enhance components.