Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

Fix unused property warning in StyleRoot #761

Closed
wants to merge 3 commits into from

Conversation

kylecesmat
Copy link
Contributor

As of React v15.2.0(facebook/react#6800) - React issues warnings for unknown properties passed to DOM nodes. This should fix the warning when using the StyleRoot component.

I haven't tested this but it seems reasonable.

Fixes #759

@coveralls
Copy link

coveralls commented Jul 1, 2016

Coverage Status

Coverage increased (+0.006%) to 96.266% when pulling 123950b on fix-unknownPropStyleRoot into 7be72ab on master.

@coveralls
Copy link

coveralls commented Jul 1, 2016

Coverage Status

Coverage increased (+0.006%) to 96.266% when pulling a3656bb on fix-unknownPropStyleRoot into 7be72ab on master.

@alexlande
Copy link
Contributor

Thanks @kylecesmat! If appveyor ever catches up, I'll merge this thing.

@conarwelsh
Copy link

+1

@sunkaflek
Copy link

+1

@alexlande
Copy link
Contributor

This doesn't do the trick, unfortunately. This prop is applied with our _cloneElement wrapper, so we can't handle it in the render method. Furthermore, this happens with all elements processed by Radium, not just StyleRoot. Taking discussion back to the open ticket to figure this out one.

@alexlande alexlande closed this Jul 5, 2016
@ianobermiller ianobermiller deleted the fix-unknownPropStyleRoot branch July 21, 2016 15:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unknown props on <div> tag
5 participants