andorid: Change authorize param order (#286)

* andorid: Change authorize param order This is a bug introduced with the order of the `authorize` function arguments. `usePKCE` should be moved to the top, in order to be compliant with the signature of the java function. * Update tests
FormidableLabs · Apr 1, 2019 · 54c9ee0 · 54c9ee0
1 parent fa50379
commit 54c9ee0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/index.js b/index.js
@@ -79,10 +79,10 @@ export const authorize = ({
   ];
 
   if (Platform.OS === 'android') {
+    nativeMethodArguments.push(usePKCE);
     nativeMethodArguments.push(clientAuthMethod);
     nativeMethodArguments.push(dangerouslyAllowInsecureHttpRequests);
     nativeMethodArguments.push(customHeaders);
-    nativeMethodArguments.push(usePKCE);
   }
 
   if (Platform.OS === 'ios') {

diff --git a/index.spec.js b/index.spec.js
@@ -165,10 +165,10 @@ describe('AppAuth', () => {
             config.scopes,
             config.additionalParameters,
             config.serviceConfiguration,
+            config.usePKCE,
             config.clientAuthMethod,
             false,
-            config.customHeaders,
-            config.usePKCE
+            config.customHeaders
           );
         });
 
@@ -182,10 +182,10 @@ describe('AppAuth', () => {
             config.scopes,
             config.additionalParameters,
             config.serviceConfiguration,
+            config.usePKCE,
             config.clientAuthMethod,
             false,
-            config.customHeaders,
-            config.usePKCE
+            config.customHeaders
           );
         });
 
@@ -199,10 +199,10 @@ describe('AppAuth', () => {
             config.scopes,
             config.additionalParameters,
             config.serviceConfiguration,
+            config.usePKCE,
             config.clientAuthMethod,
             true,
-            config.customHeaders,
-            config.usePKCE
+            config.customHeaders
           );
         });
       });
@@ -220,10 +220,10 @@ describe('AppAuth', () => {
             config.scopes,
             config.additionalParameters,
             config.serviceConfiguration,
+            config.usePKCE,
             config.clientAuthMethod,
             false,
-            customHeaders,
-            config.usePKCE
+            customHeaders
           );
         });
       });
@@ -374,10 +374,10 @@ describe('AppAuth', () => {
             config.scopes,
             config.additionalParameters,
             config.serviceConfiguration,
+            config.usePKCE,
             config.clientAuthMethod,
             false,
-            customHeaders,
-            config.usePKCE
+            customHeaders
           );
         });
       });