This repository has been archived by the owner on Dec 15, 2018. It is now read-only.
Allow url-pattern options to be specified on routes #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report@@ Coverage Diff @@
## master #136 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 19 19
Lines 231 231
=======================================
Hits 227 227
Misses 4 4
Continue to review full report at Codecov.
|
added 4 commits
January 31, 2017 22:23
Note that this reveals the unintended side-effect that the `patternOptions` are included in the matching `route`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
url-patternworks neatly for specifying parameters. However, its default options make various presumptions (notably what characters can be included in a parameter). See #107, #41 for previous issues relating to thisThis patch allows a simple extra
patternOptionsto be specified on a route; these options are passed through directly to the pattern on creation.