This repository has been archived by the owner on Dec 15, 2018. It is now read-only.
Parsing the query string on location change #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an issue when using the back button to navigate to a route that had a query string in it. It would be available in the search field, but it was not available as a query object. This commit simply performs the same parsing of the query string that the ROUTER_POP state receives.
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
=======================================
Coverage 98.41% 98.41%
=======================================
Files 19 19
Lines 253 253
=======================================
Hits 249 249
Misses 4 4
Continue to review full report at Codecov.
|
|
@tptee Are there any plans to merge this in? This is a pretty major bug. Edit: I've tried this change out and it hasn't solved the problem for me. I'll keep looking. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix #211.
Issue:
When navigating via the back button to a route which contains a query string, you will not receive a query object (parsed search string) in the payload.
Changes:
ROUTER_POPaction.