Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slide layout #1207

Closed
wants to merge 5 commits into from
Closed

Conversation

ZimChristine
Copy link
Contributor

@ZimChristine ZimChristine commented Aug 17, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
The changes in the PR add four new types of Slide Layouts: Section, Statement, Big fact, and Quote. These layouts were modeled after Keynote slide templates with the goal of making slide creation quicker and easier for common use cases.

Type of Change

  • [ x ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
The changes include adding new tests in packages/spectacle/src/components/slide-layout.test.tsx
While developing the feature, I manually consumed the layout components in the Presentation deck in index.tsx

Checklist: (Feel free to delete this section upon completion)

  • [ n/a ] I have included a changeset if this change will require a version change to one of the packages.
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas
  • [ x ] I have made corresponding changes to the documentation
  • I have run pnpm run check:ci and all checks pass
  • [ x ] I have added tests that prove my fix is effective or that my feature works
  • [ x ] My changes generate no new warnings
  • [ n/a ] Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@gksander gksander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🎈

@ZimChristine
Copy link
Contributor Author

Closed in favor of #1209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants