feat: Add new slide layouts: section, statement, big fact, quote. #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gksander
reviewed
Aug 19, 2022
There was a problem hiding this comment.
This looks great! A couple itty bitty suggestions, but I'm looking forward to launching this!
Also, I think I forgot to mention this earlier, but can you follow this section and add a changeset file to this PR so we can get this batched in with our next release?
gksander
reviewed
Aug 22, 2022
Co-authored-by: Grant Sander <gksander93@gmail.com>
Co-authored-by: Grant Sander <gksander93@gmail.com>
Co-authored-by: Grant Sander <gksander93@gmail.com>
Co-authored-by: Grant Sander <gksander93@gmail.com>
gksander
approved these changes
Aug 22, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The changes in the PR add four new types of Slide Layouts: Section, Statement, Big fact, and Quote. These layouts were modeled after Keynote slide templates with the goal of making slide creation quicker and easier for common use cases.
Type of Change
[ x ] New feature (non-breaking change which adds functionality)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
The changes include adding new tests in packages/spectacle/src/components/slide-layout.test.tsx
While developing the feature, I manually consumed the layout components in the Presentation deck in index.tsx
Checklist: (Feel free to delete this section upon completion)
[ n/a ] I have included a changeset if this change will require a version change to one of the packages.
[ x ] I have performed a self-review of my own code
[ x ] I have commented my code, particularly in hard-to-understand areas
[ x ] I have made corresponding changes to the documentation
[ x ] I have run pnpm run check:ci and all checks pass
[ x ] I have added tests that prove my fix is effective or that my feature works
[ x ] My changes generate no new warnings
[ n/a ] Any dependent changes have been merged and published in downstream modules