Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

styleBase + propTypesBase #121

Closed

Conversation

pedrottimark
Copy link
Contributor

Follow up on #108 and supersede #115

  1. styleBase(this.props, this.context) eliminates coupling to this of component for simpler testing
  2. propTypesBase so components can check base style props

Suggested order to merge Component.propTypes using Object.assign:

  1. propTypesBase
  2. props specific to component (for example, src for Image)
  3. style
  4. children

TODO in slide.js review how it uses base style props, especially the apparent restriction on margin to be a single number (instead of number or string as everywhere else). Need to review progress.js too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants