Upgrade to react-static v7 #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade to react-static v7 (#882) * Add a trailing slash for prod routes * Use local paths instead of general strings * remove double slashes * Update formidable-oss-badges * Infra/Docs: Have one build/basepath for staging/prod/dev (#884) - Switch dev + staging + prod **all** to one basepath (always `/open-source/spectacle`) - Collapse build/serve commands to `build` and `serve` and remove / replace config / symlink files now no longer needed. - Make the static build served from 4000 so dev can serve on 3000 - Rename deploy commands. - Have AWS deploy go off `dist/open-source/spectacle` instead of `dist`. (Surge build stays the same file-location-wise). * Badges should route to project docs * button as external a tag rather than react-router Link Co-authored-by: boygirl <lauren.eastridge@formidable.com> Co-authored-by: Ryan Roemer <ryan.roemer@formidable.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FourthFifth time's the charm 馃You can test out the staged deploy, but our issue is only occurring in prod so we will have to merge & test the production site.