Task/docs rewrite #882
Merged
Task/docs rewrite #882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kale-stew
approved these changes
Apr 20, 2020
Contributor
kale-stew
left a comment
kale-stew
left a comment
There was a problem hiding this comment.
Looks great both staged and local, but I know our issues are consistently surfacing in prod, so going to merge and QA the Real docs site. 🤞
Contributor
|
Rel #878, when we fix this we'll have closed that issue as well |
kale-stew
pushed a commit
that referenced
this pull request
Apr 20, 2020
* Upgrade to react-static v7 (#882) * Add a trailing slash for prod routes * Use local paths instead of general strings * remove double slashes * Update formidable-oss-badges * Infra/Docs: Have one build/basepath for staging/prod/dev (#884) - Switch dev + staging + prod **all** to one basepath (always `/open-source/spectacle`) - Collapse build/serve commands to `build` and `serve` and remove / replace config / symlink files now no longer needed. - Make the static build served from 4000 so dev can serve on 3000 - Rename deploy commands. - Have AWS deploy go off `dist/open-source/spectacle` instead of `dist`. (Surge build stays the same file-location-wise). * Badges should route to project docs * button as external a tag rather than react-router Link Co-authored-by: boygirl <lauren.eastridge@formidable.com> Co-authored-by: Ryan Roemer <ryan.roemer@formidable.com>
kale-stew
pushed a commit
that referenced
this pull request
Apr 21, 2020
* Upgrade to react-static v7 (#882) * Add a trailing slash for prod routes * Use local paths instead of general strings * remove double slashes * Update formidable-oss-badges * Infra/Docs: Have one build/basepath for staging/prod/dev (#884) - Switch dev + staging + prod **all** to one basepath (always `/open-source/spectacle`) - Collapse build/serve commands to `build` and `serve` and remove / replace config / symlink files now no longer needed. - Make the static build served from 4000 so dev can serve on 3000 - Rename deploy commands. - Have AWS deploy go off `dist/open-source/spectacle` instead of `dist`. (Surge build stays the same file-location-wise). * Badges should route to project docs * button as external a tag rather than react-router Link Co-authored-by: boygirl <lauren.eastridge@formidable.com> Co-authored-by: Ryan Roemer <ryan.roemer@formidable.com> Co-authored-by: boygirl <lauren.eastridge@formidable.com> Co-authored-by: Ryan Roemer <ryan.roemer@formidable.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the base path to the sidebar links. mdx links were already working as expected