Skip to content
This repository has been archived by the owner on Aug 4, 2020. It is now read-only.

Docs on webpack builds with Victory #24

Closed
boygirl opened this issue May 6, 2016 · 6 comments
Closed

Docs on webpack builds with Victory #24

boygirl opened this issue May 6, 2016 · 6 comments
Assignees

Comments

@boygirl
Copy link
Contributor

boygirl commented May 6, 2016

From @knowbody on January 3, 2016 17:51

Write a comprehensive guide of how to build Victory components in your project with webpack the "right" way considering:

  • Source Maps
  • Overall build composition
  • Pointing to lib/ vs. src/
  • Dependency management and flattening for things like lodash, React, et.c

This should go in the main victory README.

Copied from original issue: FormidableLabs/victory#145

@boygirl
Copy link
Contributor Author

boygirl commented May 6, 2016

From @coopy on January 20, 2016 21:37

Closing - npm3 requirement is in docs

@boygirl
Copy link
Contributor Author

boygirl commented May 6, 2016

From @ryan-roemer on January 21, 2016 0:8

@coopy -- This is supposed to be a comprehensive guide of how to build Victory components in your project with webpack the "right" way considering:

  • Source Maps
  • Overall build composition
  • Pointing to lib/ vs. src/
  • Dependency management and flattening for things like lodash, React, et.c

Do we have all that already?

@boygirl
Copy link
Contributor Author

boygirl commented May 6, 2016

From @coopy on January 21, 2016 0:29

Ah, I interpreted the issue as just a followup to FormidableLabs/victory#144, which was a npm2 based issue. Reopening. Thanks for the details!

@boygirl
Copy link
Contributor Author

boygirl commented May 6, 2016

From @coopy on March 8, 2016 22:13

@paulathevalley
Copy link
Contributor

Hi team! What’s the status on this issue? Is it still relevant? If yes, who will be on point for writing it?

@ryan-roemer
Copy link
Member

@paulathevalley -- We should roll this work into FormidableLabs/victory#256

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants