Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs on webpack builds with Victory #145

Closed
knowbody opened this issue Jan 3, 2016 · 5 comments
Closed

Docs on webpack builds with Victory #145

knowbody opened this issue Jan 3, 2016 · 5 comments
Assignees
@coopy

Comments

@knowbody
Copy link
Contributor

knowbody commented Jan 3, 2016

Write a comprehensive guide of how to build Victory components in your project with webpack the "right" way considering:

  • Source Maps
  • Overall build composition
  • Pointing to lib/ vs. src/
  • Dependency management and flattening for things like lodash, React, et.c

This should go in the main victory README.
@coopy coopy added this to the Alpha 2 milestone Jan 3, 2016
knowbody added a commit that referenced this issue Jan 4, 2016
@knowbody
Update README.md
442d711 
remove the npm version note as is not relevant here, needs to be added to the webpack build docs (#145 #146)
@knowbody knowbody mentioned this issue Jan 4, 2016
Closed
@coopy
Copy link
Contributor

coopy commented Jan 20, 2016

Closing - npm3 requirement is in docs

@coopy coopy closed this as completed Jan 20, 2016
@ryan-roemer
Copy link
Member

@coopy -- This is supposed to be a comprehensive guide of how to build Victory components in your project with webpack the "right" way considering:

  • Source Maps
  • Overall build composition
  • Pointing to lib/ vs. src/
  • Dependency management and flattening for things like lodash, React, et.c

Do we have all that already?

@coopy
Copy link
Contributor

coopy commented Jan 21, 2016

Ah, I interpreted the issue as just a followup to #144, which was a npm2 based issue. Reopening. Thanks for the details!

@coopy coopy reopened this Jan 21, 2016
@coopy coopy mentioned this issue Jan 21, 2016
Closed
@coopy coopy self-assigned this Mar 1, 2016
@coopy
Copy link
Contributor

coopy commented Mar 8, 2016

This was referenced May 6, 2016
Open
Closed
@boygirl
Copy link
Contributor

boygirl commented May 6, 2016

This issue was moved to FormidableLabs/victory-docs#24

@boygirl boygirl closed this as completed May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coopy coopy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ryan-roemer @coopy @boygirl @knowbody