This repository has been archived by the owner on Aug 4, 2020. It is now read-only.
Add "live" chart to homepage #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc all my frnds @ebrillhart @paulathevalley @boygirl |
|
Styles and UI look really nice! Should get JS code review by a more senior dev /cc DOSS @kenwheeler |
|
|
||
| const LiveChart = ({data, duration, domain}) => ( | ||
| <VictoryChart | ||
| animate={{ duration: 1000 }} |
There was a problem hiding this comment.
If this code is editable you might want to express this animation duration in terms of props.duration
There was a problem hiding this comment.
Yeah, you're right. Or rename props.duration. That name is kind of misleading at this point.
There was a problem hiding this comment.
✅ cleared this up
|
@chrisbolin looking good! |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #69
Note: the "VIEW SOURCE" link will work only after this branch is merged.