Add activePoints props to flyout & label components in voronoi container #1474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…ainer Add a demo to show what it enables Fixes FormidableLabs#1473
|
@jotak thank you for this straightforward solution. I like it! I'll get a patch out for you tonight. |
|
Thanks @boygirl ! |
|
EDIT: Actually found it: e4dea7b#diff-4ac32a78649ca5bdd8e0ba38b7006a1e ; cheers |
|
The change log has been my source of truth: https://github.com/FormidableLabs/victory/blob/master/CHANGELOG.md#3400-2019-12-20 apologies for any confusion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a demo to show what it enables
Fixes #1473
Notes: I've added a demo, not a story, because there's a comment in stories stating "only add visual test for containers that have visual elements without interaction" which isn't the case here (interactions are needed to trigger tooltip)