Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid rerenders on ignored events #1723

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Avoid rerenders on ignored events #1723

merged 1 commit into from
Oct 20, 2020

Conversation

Hypnosphi
Copy link
Contributor

Issue: Victory codebase uses return {} as a way of saying "ignore this event", but it still leads to rerendering of VictorySharedEvents and therefore its children

@boygirl
Copy link
Contributor

boygirl commented Oct 20, 2020

@Hypnosphi Thanks for this improvement!

@boygirl boygirl merged commit cee09c1 into FormidableLabs:main Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hypnosphi @boygirl