Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon-edit is not using the entire vertical space #1007

Closed
jbranc opened this issue May 7, 2013 · 4 comments
Closed

icon-edit is not using the entire vertical space #1007

jbranc opened this issue May 7, 2013 · 4 comments
Assignees
Milestone

Comments

@jbranc
Copy link

jbranc commented May 7, 2013

when icon-edit is sitting next to other icons of the same size, it appears to be shorter than the rest. it seems the bottom of the square doesn't go all the way to the bottom of the icon, so as a result it can look 'off' while in a line. Its especially noticeable when you stick icon-edit next to icon-trash.

@tagliala
Copy link
Member

yes, unfortunately some icons are not of the same height.

If I well remember, icons like icon-phone are intentionally smaller than others

Labeling this as enhancement

@tagliala
Copy link
Member

tagliala commented Mar 9, 2015

Assigned to @davegandy

More info here: #5882

@luisrudge
Copy link

Here are the pics:

@tagliala
Copy link
Member

Seems fixed to me https://jsfiddle.net/tagliala/qq2eLxo1/18/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants