-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading the master branch to Font Awesome 5 #12199
Comments
@tagliala we are prepping for converting the main repository over to be Font Awesome 5. Brian wisely asked if we should go over this with you. I've listed some of the items that specifically we need to think about. When you get some time give us your thoughts. We aren't going to make this transition until all of us are comfortable with it. |
@robmadole thanks for bringing this to my attention
Seems good to me 👍
Contributors = Contributing guidelines? They are awesome! I hope that the users will not be discouraged to post new requests. I mean, we don't need a single color example for "car", but I definitely need a single color example of "traveling", because it could be a duplicate of an existing issue (airplane leaving) or it could be already here (airplane)
Amazing!
Do we have choices? They could be shutted down from settings, and Contributing guidelines could be edited accordingly. If the free repo source code is generated by the build system, merged PRs will be lost in any case. Is there any chance of cherry-pick commits and use them in the build system?
Don't know your plans for managing requests, other issues will require more thoughts on my side
Don't worry, I will adapt to the new workflow.
Beside the package.json stuff, I cannot help here.
Readme has a lot of links, I could use reply templates on case-by-case basis, to provide more information if needed (e.g: CDN outage) |
I'll soften this language a bit. Good catch.
Well, we have a choice in the saved response we can use. The more I think about it the more I'm convinced that we need to close all of them. They just will not be applicable any longer once we merge this.
No chance for a cherry-pick since the build system doesn't actually contain these files. I've added
We have a chance here to reverse some of the "abandoned community" feel we've earned. @tagliala you've done an amazing job of keeping on top of this project and for the most part we (devs) haven't followed through. That needs to change but we don't have a concrete plan yet. I'd like to earn some trust back with the community.
Okay. But if there is something we can do to help you please let us know. You've contributed so much to Font Awesome and have earned a vote at the table. I learned quickly to listen to you when you've brought things up. |
I'm fine for all of the above points @robmadole I have a thin icon label for requests. I think we can shut down those requests: people needing light icons could go for FA Pro (or other free sets of their choice) |
Hello I'm happy to see that you plan to finally merge 5.0 into master. But I'm a little concerned on how this will play for icon contributors. As I understand it, you have redesigned the whole set plus a whole lot more icons. You've also added 2 more styles to the icons, which will not be part of the free set. And you've done all this over the course of last year supported by a very successful kickstarter campaign. Really congratulations on all that achievement. It's quite amazing and inspiring. But how will the community collaboration play in the future?
I'd really appreciate an explanation on your intentions and what you expect from the community. Because my understanding here is that this repo will probably just be a file hosting service for the free compiled version of this project and the issues will only be used for icon request and bug reports. I still don't see why someone would do a PR with all this. Thanks for you time and looking forward to read you. |
Make a new repository/branch for V4 and shove everything in there? |
@xuv we don't accept icon contributions currently and that won't change with 5. PRs are a great way to illustrate where we have a problem. It's easy to point to code and it can sometimes be the best example. Because Font Awesome sales a Pro version our build system will for the time being remain private (we've got all of our for-pay icons in there). We hope that the community will continue much in the same way that it has. Submitting icon requests, bug reports, and using this repo as a way to communicate. |
@robmadole: thanks for the explanation. |
This transition has now been made 👍 |
@robmadole thanks for the switch I was updating my saved replies but templates don't seem to work How to reproduce
edit: |
Got it! Nice catch, sir. |
Fixed in |
Please make a CDN that autoupdates to latest FontAwesome version. Something like this: Thank you. |
Creating an issue to discuss the logistics of migrating
master
to Font Awesome 5.The
fa-5
branch currently contains the proposed new tree. Note that this new branch is not associated (a descendent) of the current 4.x master branch.Things to work through
.github/ISSUE_TEMPLATE
package.json
file, ability to install from GitHub)Main collaborators on this effort:
The text was updated successfully, but these errors were encountered: