Mark css as having side effects in @fortawesome/fontawesome-svg-core #18654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Just ran into the same issue. Please fix for CSP compatibility 👍🏾 |
|
Thanks for the report! We can get this done. Out of curiosity, @GertSallaerts have you confirmed that this change fixes the issue for you? |
|
@robmadole yes, this fixed the problem for us. |
kaliatech
added a commit
to kaliatech/website-kaliatech
that referenced
this pull request
Mar 15, 2022
kaliatech
added a commit
to kaliatech/website-kaliatech
that referenced
this pull request
Mar 15, 2022
|
@robmadole Can we please move forward on this? 🙂 |
|
Hello
My dear friend, I did not understand exactly what you meant.
Can you explain more?
Nik Sauer ***@***.***> در تاریخ چهارشنبه ۸ ژوئن ۲۰۲۲
ساعت ۲۰:۳۶ نوشت:
… @robmadole <https://github.com/robmadole> Can we please move forward on
this? 🙂
—
Reply to this email directly, view it on GitHub
<#18654 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH3WNYG7OBC5Z7LTBYTPTMTVODAHDANCNFSM5N2RBA4Q>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
@robmadole Should I open a rebased PR or how would you like to proceed? We'd love to upgrade to v6 but this is a blocker. |
|
This has been fixed in 6.1.0 Closing here, thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are manually importing the
styles.cssfile in our project (to make our site work with our CSP policy as described in the docs) by including animport '@fortawesome/fontawesome-svg-core/styles.css';statement in our code. This was working perfectly before the 1.3 release of@fortawesome/fontawesome-svg-corebut because of thesideEffectsconfiguration, webpack is now treeshaking the CSS out of our build.We have some other workarounds available to use but thought it might help other users to include it here?