Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing t-shirt sizes to SizeProp type #18789

Closed
wants to merge 1 commit into from
Closed

Add missing t-shirt sizes to SizeProp type #18789

wants to merge 1 commit into from

Conversation

daven97
Copy link

@daven97 daven97 commented Mar 7, 2022

Fixes #18788

@daven97 daven97 mentioned this pull request Mar 7, 2022
Closed
@filippofilip95
Copy link

I would really appreciate it to have this merged :)

@jkossis
Copy link

jkossis commented Jul 20, 2022

@robmadole any chance we could get this merged?

@robmadole
Copy link
Member

We didn't accomplish this for 6.1.2 but we'll try for the next release.

@tagliala tagliala mentioned this pull request Aug 14, 2022
Closed
1 task
@robmadole
Copy link
Member

This has been fixed and will go out in 6.2.0.

@jkossis
Copy link

jkossis commented Aug 19, 2022

@robmadole is there a commit/pr that this fix can be linked back to? I couldn't seem to find the corresponding commit.

Would help in the closure of this ticket.

@robmadole
Copy link
Member

This should be fixed in 6.2.0. Give it a go when you can and let me know if it doesn't fix it (I'll re-open)

@robmadole robmadole closed this Sep 2, 2022
@daven97
Copy link
Author

daven97 commented Oct 11, 2022 •
edited

Sorry I missed that this PR had been closed. This is working for me now in 6.2.0! Thanks!

@daven97 daven97 deleted the daven97/fixTypeScriptError branch October 11, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filippofilip95 filippofilip95 filippofilip95 approved these changes

@thetimehacker thetimehacker thetimehacker approved these changes

@ddevsr ddevsr ddevsr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript: Some T-shirt sizes not listed in SizeProps
6 participants
@daven97 @filippofilip95 @jkossis @robmadole @thetimehacker @ddevsr