Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified To Retro-Fit Support For Newer Text Rendering Optimizations #3136

Closed
wants to merge 4 commits into from

Conversation

Lewiscowles1986
Copy link

really it consists of 3 lines of CSS, we also included mixins for less and css if you feel they are a better fit as options for designers

Just cleaned Up the rendering a little
added smooth-text mixin
mirrored changed to SCSS
mirrored changes to SCSS
@tagliala
Copy link
Member

https://github.com/blog/1135-the-making-of-octicons

Browsers use subpixel rendering by default. This looks great for text, but left the icons looking a little heavy as a result of the extra pixels it adds.

This is why fontawesome is using -webkit-font-smoothing: antialiased; instead of the default

AFAIK optimizeLegibility only add some incompatibilities with phonegap: https://github.com/FortAwesome/Font-Awesome/wiki/Troubleshooting#phonegap--android-icons-in-heading-tags

I'm curious about the tiny shadow, I will take a look

@robmadole
Copy link
Member

First off, thanks for spending the time to post this PR. It's sat in the Font Awesome GitHub repo for far too long and we should have responded or addressed the work that you put into this.

Over the past year we've been hard at work on Font Awesome 5. It's now released and this PR no longer applies. So we're going to close it (with an apology for being so tardy).

If you think the work from this still applies feel free to reply and we'll take a second look.

– FA team

@robmadole robmadole closed this Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants