Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine size and color APIs #15

Merged
merged 26 commits into from
Jan 7, 2019
Merged

Refine size and color APIs #15

merged 26 commits into from
Jan 7, 2019

Conversation

mlwilkerson
Copy link
Member

@mlwilkerson mlwilkerson commented Jan 5, 2019 •
edited
Loading

  • Ensure extra props are still passed through (code has been commented out)
  • Consider how to handle sizes specified in StyleSheet properties: width, height, fontSize

@mlwilkerson
Add basic (failing) test for color prop
44c67b2
@mlwilkerson
Change handling of color prop
882dae6
@mlwilkerson
Make style prop default to an empty object
f328dce
@mlwilkerson
Update snapshots after changing color prop handling
652fb8a
@mlwilkerson
Delete color property on style object after resolving the fill color
482793b
@mlwilkerson
streamline testing
16ec2d5 
- remove some snapshot testing in favor of testing specific tree object
  properties

- test the case where color prop should override style
@mlwilkerson
Add doc about color
cd66d7d
@mlwilkerson
expand color prop explanation
296b917
@mlwilkerson
Change size handling
8be1a26 
- add size prop
- deprecate height and width props
- add test coverage
- re-organize tests
@mlwilkerson
Rebuild dist
9071c0d
@mlwilkerson
Use object spread operator to remove color property from style object…
6145312 
… instead of delete operator
@mlwilkerson
improve color testing
798fc56
@mlwilkerson
Rebuild dist
33463d2
@mlwilkerson
Strip away any fill attributes on elements returned by fontawesome-sv…
fad906b 
…g-core
@mlwilkerson
export default size and color, and set a default color of #000
1133623
@mlwilkerson
Fix up tests after stripping away fill attributes
eb2a606
@mlwilkerson
rebuild dist
9b52d8b
@mlwilkerson
Only delete the fill attribute when its value is currentColor.
6fc5900 
We need it to remain when the value is "white", since that's what it
will be when doing a mask.
@mlwilkerson
Rebuild dist
7837ad4
@mlwilkerson
Add some example icons that use react-native-svg directly, for compar…
293cc53 
…ison

and visual experimentation
@mlwilkerson
refinements
cf78e43
@mlwilkerson
Document size prop
ebc7c96
@mlwilkerson
Re-enable and test the passing through of extraProps
bdc77fe
@mlwilkerson
Rebuild dist
810586a
@mlwilkerson
And undefined prop defaults for height and width to fix handling of
951c1d6 
default/override logic with height/width/size
@mlwilkerson
Rebuild dist
6a64c18
@mlwilkerson mlwilkerson merged commit 0c1a4d1 into master Jan 7, 2019
@mlwilkerson mlwilkerson deleted the refine-api branch January 7, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mlwilkerson