Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<font-awesome-icon> title property breaks snapshots #181

Closed
scottdickerson opened this issue Jun 13, 2019 · 3 comments
Closed

<font-awesome-icon> title property breaks snapshots #181

scottdickerson opened this issue Jun 13, 2019 · 3 comments
Assignees

Comments

@scottdickerson
Copy link

If I add the title property to font-awesome, it dynamically adds an aria-labelledby to the rendered svg. The problem is this title is dynamically generating an id, so the aria-labelledby always changes, which invalidates my Jest snapshots.

Can we please add an id prop to font-awesome-icon that if set, will guarantee that the title element always gets generated with consistent ids.

@scottdickerson scottdickerson changed the title title property breaks snapshots <font-awesome-icon> title property breaks snapshots Jun 13, 2019
@chococrypto
Copy link

Did you solve it ?

@johachi
Copy link

johachi commented Jun 8, 2020

This seems to be solvable by mocking Math.random: FortAwesome/react-fontawesome#194

@jasonlundien
Copy link
Member

Closing issue, fixed with PR Vue 3x - Update for titleId and maskId prop #455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants