Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing relative sizing values in v3 / FA6 branch #326

Closed
ux-engineer opened this issue Sep 2, 2021 · 2 comments
Closed

Missing relative sizing values in v3 / FA6 branch #326

ux-engineer opened this issue Sep 2, 2021 · 2 comments

Comments

@ux-engineer
Copy link

In FA6 documentation about sizing, in relative sizing section, there are these sizing values available: 2xs, xs, sm, lg, xl, 2xl

Your Vue component's size property validator is missing these values: 2xs, xl, 2xl

You also might want to consider allowing undefined value to be used along with null, as an empty value.

@AndreiHudovich
Copy link

2.x branch (the right number of sizes):

validator: (value) => ['2xs', 'xs', 'sm', 'lg', 'xl', '2xl', '1x', '2x', '3x', '4x', '5x', '6x', '7x', '8x', '9x', '10x'].indexOf(value) > -1

3.x branch:

validator: (value) => ['lg', 'xs', 'sm', '1x', '2x', '3x', '4x', '5x', '6x', '7x', '8x', '9x', '10x'].indexOf(value) > -1

This leads to Vue warns when using missing sizes:

[Vue warn]: Invalid prop: custom validator check failed for prop "size".

@jasonlundien
Copy link
Member

@ux-engineer & @andrei-hudovich ---

We have updated our Vue 3 (official now) package to include the relative sizing. You should be good to go now. I will go ahead and close this issue. If you feel that it needs to remain open just let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants