We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug Types in index.d.ts FontAwesomeIconProps do not match actual expected props in FontAwesomeIcon.js.
Expected behavior Exact match of supported props and associated types definition.
Reproduction Unintuitive breakage due to missing types, string "false" evaluates to true:
"false"
Functioning code to pass boolean false value instead of string, which consuming developer would know to use if types were present:
false
Additional context Issue introduced by: #366 PR merged under #415 fixed one piece of the issue, but left much of the issue remaining.
Exact diff of expected types
+ bounce?: boolean + shake?: boolean + beat?: boolean + fade?: boolean + beatFade?: boolean + flash?: boolean + spinPulse?: boolean + spinReverse?: boolean
The text was updated successfully, but these errors were encountered:
@brandon-mork ---
Oh my goodness, you are right, I missed them... somehow (I have no idea how).
I will get this PR submitted and merged as well. Thank you !!!
Sorry, something went wrong.
You rock- thanks @jasonlundien!! :)
PR merged. So I am going to go ahead and close this one now. Thanks again for your help.
Also, I am going to add you as a contributor unless you tell me other wise. Have a great one !!!
jasonlundien
Successfully merging a pull request may close this issue.
Describe the bug
Types in index.d.ts FontAwesomeIconProps do not match actual expected props in FontAwesomeIcon.js.
Expected behavior
Exact match of supported props and associated types definition.
Reproduction
Unintuitive breakage due to missing types, string
"false"
evaluates to true:Functioning code to pass boolean
false
value instead of string, which consuming developer would know to use if types were present:Additional context
Issue introduced by: #366
PR merged under #415 fixed one piece of the issue, but left much of the issue remaining.
Exact diff of expected types
The text was updated successfully, but these errors were encountered: