Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x Types Issue: FontAwesomeIconProps missing values #415

Closed
brandon-mork opened this issue Nov 11, 2022 · 2 comments · Fixed by #427
Closed

3.x Types Issue: FontAwesomeIconProps missing values #415

brandon-mork opened this issue Nov 11, 2022 · 2 comments · Fixed by #427
Assignees

Comments

@brandon-mork
Copy link

Describe the bug
Types in index.d.ts FontAwesomeIconProps do not match actual expected props in FontAwesomeIcon.js.

Expected behavior
Exact match of supported props and associated types definition.

Reproduction
In any typescript app consuming v3.0.2 of vue-fontawesome, attempt to utilize prop size="xl". See type error:
error TS2322: Type '"xl"' is not assignable to type '"lg" | "xs" | "sm" | "1x" | "2x" | "3x" | "4x" | "5x" | "6x" | "7x" | "8x" | "9x" | "10x" | undefined'.

Additional context
Issue introduced by: #366

Exact diff of expected types

- size?:         'xs' | 'sm' | 'lg'                | '1x' | '2x' | '3x' | '4x' | '5x' | '6x' | '7x' | '8x' | '9x' | '10x'
+ size?: '2xs' | 'xs' | 'sm' | 'lg' | 'xl' | '2xl' | '1x' | '2x' | '3x' | '4x' | '5x' | '6x' | '7x' | '8x' | '9x' | '10x'
+ bounce?: boolean
+ shake?: boolean
+ beat?: boolean
+ fade?: boolean
+ beatFade?: boolean
+ flash?: boolean
+ spinPulse?: boolean
+ spinReverse?: boolean
brandon-mork pushed a commit to brandon-mork/vue-fontawesome-issue-415 that referenced this issue Nov 11, 2022
…o match actual expected props in FontAwesomeIcon.js.
@jasonlundien jasonlundien linked a pull request Jan 3, 2023 that will close this issue
@jasonlundien jasonlundien self-assigned this Jan 3, 2023
@jasonlundien
Copy link
Member

@brandon-mork ---

I have added in the missing sizes. I will go ahead and close this issues. Let us know if anything else pops up.

@brandon-mork
Copy link
Author

@jasonlundien your PR fails to sync the other props available on the component but missing in the types... Logged as a separate issue: #428

Provided PR would have fixed all of the documented issues: #416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants