Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add vue 3 reactivity support #297

Merged
merged 1 commit into from May 23, 2021
Merged

add vue 3 reactivity support #297

merged 1 commit into from May 23, 2021

Conversation

otijhuis
Copy link
Contributor

Fixes #250

@otijhuis
Copy link
Contributor Author

vue 3 version update seemed to be needed, otherwise I got the following error inside my test application:

'h' is not exported by ../vue-fontawesome/node_modules/vue/dist/vue.runtime.esm.js, imported by ../vue-fontawesome/index.es.js

@otijhuis otijhuis mentioned this pull request Mar 28, 2021
Closed
@robmadole robmadole merged commit 7e43ea5 into FortAwesome:3.x May 23, 2021
@robmadole
Copy link
Member

Thanks a bunch @otijhuis . Really appreciate it. Going to get another RC out now.

matthew-e-brown added a commit to matthew-e-brown/cotera.io that referenced this pull request Jul 30, 2021
@matthew-e-brown
Remove FontAwesome key for reactive icon
c63f97f 
- Now that FortAwesome/vue-fontawesome#297 has been merged, a :key is no
  longer needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@otijhuis @robmadole