Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue3 - update workflows ci #377

Merged
merged 6 commits into from Jan 6, 2023
Merged

Vue3 - update workflows ci #377

merged 6 commits into from Jan 6, 2023

Conversation

jasonlundien
Copy link
Member

@jasonlundien jasonlundien commented Jun 9, 2022

This PR updates the workflows ci.yml file to include more of the matrix style testing including the different versions of Vue and Font Awesome.

Reviewers:
@robmadole --- will you review for accuracy and see if I have missed anything ?

Dependencies:
none

@jasonlundien jasonlundien marked this pull request as ready for review June 9, 2022 20:00
@jasonlundien jasonlundien force-pushed the update-workflows-ci branch 7 times, most recently from 426c8fa to b6b86fc Compare June 9, 2022 21:25
@jasonlundien jasonlundien changed the title update workflows ci Vue3 - update workflows ci Jun 17, 2022
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@robmadole
Copy link
Member

@jasonlundien it's starting to come back to me a bit!

We need to update package.json.

"test": "npm run test.5 && npm run test.6",
    "test.5": "npm --no-save install @fortawesome/fontawesome-svg-core@1.2.x @fortawesome/free-solid-svg-icons@5.x && jest --silent",
    "test.6": "npm --no-save install @fortawesome/fontawesome-svg-core@6.x @fortawesome/free-solid-svg-icons@6.x && jest --silent",

We don't need the separate test.5 test.6. We should be able to just run jest --silent.

@jasonlundien jasonlundien force-pushed the update-workflows-ci branch 7 times, most recently from 8ba2143 to 2e59968 Compare January 6, 2023 21:35
@jasonlundien jasonlundien force-pushed the update-workflows-ci branch 2 times, most recently from 1520fd9 to 029132d Compare January 6, 2023 21:52
@jasonlundien jasonlundien merged commit 4241f0d into 3.x Jan 6, 2023
@jasonlundien jasonlundien deleted the update-workflows-ci branch January 6, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants