Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues with code blocks and listing of source files #576

Merged
merged 6 commits into from
Oct 17, 2023

Conversation

ZedThree
Copy link
Member

@ZedThree ZedThree commented Oct 17, 2023

Fixes #575

@zoziha Please could you check to see if this fixes your issues?

Fixes:

  • code blocks not wrapping
  • code highlighting not working
  • "Source File" navbar link not working for single file projects
  • duplicated source files on case insensitive filesystems

@zoziha
Copy link

zoziha commented Oct 17, 2023

Thanks @ZedThree , regarding "code highlighting, code blocks not wrapping", these two problems are almost solved, but it seems that the background of the code blocks is not rounded now, the boundaries aren't very clear, and the display seems to be not as refined as in ford-v6.0. For example:

ford-v6.0-screenshot

image

ford-v7.0-screenshot-1

image

Secondly, I noticed that the source code under the procedures option is not getting highlighted:

ford-v7.0-screenshot-2

image

As we now find files using a glob for each individual file extension,
case insensitive filesystems will find the same file for both
extensions that only differ by case.

An alternative fix for this might be to squash all the extensions into
a single glob pattern and run that in each directory
@ZedThree
Copy link
Member Author

Some of the fonts and colours have changed due to the upgrade of the Bootstrap CSS framework, and I'm afraid I don't have massive amounts of time to recreate everything, but I will try and fix the boundaries of the code blocks at least.

I probably just broke the procedures highlighting in this PR, I'll fix that now. Thanks!

I think I've now got a fix for the repeated files on Windows. Would you mind giving it a test?

@zoziha
Copy link

zoziha commented Oct 17, 2023

Thanks for fixing it so quickly @ZedThree , I tried this PR and all the previously mentioned issues were fixed, much appreciated :)
No double counting of source files, procedures syntax highlighting works fine, I understand that style improvements take more time, thanks again!

@ZedThree ZedThree changed the title Fix code highlighting, code blocks not wrapping, and broken Source Files link Fix some issues with code blocks and listing of source files Oct 17, 2023
@ZedThree ZedThree merged commit 32d6044 into master Oct 17, 2023
10 checks passed
@ZedThree ZedThree deleted the fix-code-highlighting branch October 17, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Three potential issues with version 7.0
2 participants