Merge pull request #9433 from ForumMagnum/custom-onmousedown-before-m…

…odifier-return

run custom onMouseDown logic before doing an early return for modifier keys

packages/lesswrong/components/common/HashLink.tsx

@@ -94,10 +94,12 @@ export function HashLink(props: HashLinkProps) {
       {...filteredProps}
       href={to}
       onMouseDown={(ev) => {
+        // Run any custom onMouseDown logic, including event tracking (such as that passed in from `Link`) before checking for modifier keys
+        // This is necessary to capture e.g. `linkClicked` events when cmd-clicking to open links in a new tab
+        filteredProps.onMouseDown?.(ev);
         if (ev.metaKey || ev.altKey || ev.ctrlKey || ev.shiftKey || ev.button !== 0) {
           return;
         }
-        filteredProps.onMouseDown?.(ev)
         navigate(to);
         ev.preventDefault();
       }}