Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing compound index prefix match #78

Merged
merged 2 commits into from
Feb 14, 2019
Merged

Conversation

apkar
Copy link
Contributor

@apkar apkar commented Feb 14, 2019

Query planner matches compound indexes incrementally. Bug exists in this part of the code such that, if the predicate is on A and B and if it matches first with index A_C, then later stages of the incremental check instead of looking for index match A_B, it looks for A_C_B. This patch fixes that issue.

This fixes #46 and also fixes #38

Copy link
Contributor

@dongxinEric dongxinEric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets fix the bug in getCompoundIndex()

Copy link
Contributor

@dongxinEric dongxinEric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Will merge once CI passes.

@apkar apkar merged commit e4c0d21 into FoundationDB:master Feb 14, 2019
@apkar apkar deleted the index-cleanup branch February 21, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants