Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NullStandin should be set in FieldKeyExpression::toProto #626

Closed
prabhat1081 opened this issue Jun 5, 2019 · 0 comments
Closed

NullStandin should be set in FieldKeyExpression::toProto #626

prabhat1081 opened this issue Jun 5, 2019 · 0 comments
Assignees
@MMcM

Comments

@prabhat1081
Copy link

Currently, the optional field nullInterpretation is not set in FieldKeyExpression.toProto and hence when loading the metadata from RecordMetadataStore, it gets defaulted to NOT_UNIQUE/NULL.
@MMcM MMcM self-assigned this Jun 5, 2019
alecgrieser added a commit that referenced this issue Jun 5, 2019
@alecgrieser
Merge pull request #627 from MMcM/field-expression-serialize-null-sta…
3c931c6 
…ndin

Fixes #626: NullStandin should be set in FieldKeyExpression::toProto
MMcM added a commit to MMcM/fdb-record-layer that referenced this issue Jul 18, 2019
@MMcM
Revert "Fixes FoundationDB#626: NullStandin should be set in FieldKey…
26ecd5d 
…Expression::toProto"

This reverts commit 85b09f1.
MMcM added a commit to MMcM/fdb-record-layer that referenced this issue Jul 19, 2019
@MMcM
Revert "Fixes FoundationDB#626: NullStandin should be set in FieldKey…
219d62e 
…Expression::toProto"

This reverts commit 85b09f1.
alecgrieser added a commit that referenced this issue Jul 19, 2019
@alecgrieser
Merge pull request #653 from MMcM/revert-null-interpretation
87eaf87 
Revert "Fixes #626: NullStandin should be set in FieldKeyExpression::toProto"
MMcM added a commit to MMcM/fdb-record-layer that referenced this issue Jul 30, 2019
@MMcM
Fixes FoundationDB#626: NullStandin should be set in FieldKeyExpressi…
7a70190 
…on::toProto
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MMcM MMcM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MMcM @prabhat1081