Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RK4 timestepper is wrong #97

Closed
navidcy opened this issue Dec 26, 2018 · 1 comment
Closed

RK4 timestepper is wrong #97

navidcy opened this issue Dec 26, 2018 · 1 comment

Comments

@navidcy
Copy link
Member

navidcy commented Dec 26, 2018

The last substep of RK4 time-stepper is wrong.

Lines:

FourierFlows.jl/src/timesteppers.jl

Line 205 in 7a929e3

substepsol!(ts.sol₁, sol, ts.RHS₃, cl.dt)

FourierFlows.jl/src/timesteppers.jl

Line 224 in 7a929e3

substepsol!.(ts.sol₁, sol, ts.RHS₃, cl.dt)

should be substepsol!(ts.sol₁, sol, 2*ts.RHS₃, cl.dt) (since substepsol! has a 0.5 in front of dt. Better solution is to rewrite substepsol! without the 0.5 factor.

@glwagner: I'm submitting a PR to fix this.
@navidcy
Copy link
Member Author

navidcy commented Dec 27, 2018

PR #98 resolves the issue

@navidcy navidcy closed this as completed Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@navidcy