Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the RK4 time-stepper and the Diiffusion test module #98

Merged
merged 4 commits into from Dec 27, 2018

Conversation

navidcy
Copy link
Member

@navidcy navidcy commented Dec 27, 2018

  • corrects substep Can't use calc_nl_2DQG! -- used calc_nl_2DQG instead #4 of RK4 & FilteredRK4 time-steppers
  • fixes the calcN! function for constant diffusivity case
  • fixes the calcN! function (ldiv! --> mul!) for the case with varying diffusivity
  • adds a varying-diffusivity test case so that stepforward! calls calcN! instead of just L*sol

- fixes the calcN! function for constant diffusivity case
- fixes the calcN! function ldiv --> mul for the case with varying diffusivity
- adds a varying-diffusivity test case so that stepforward! calls calcN! instead of just L*sol
@navidcy navidcy changed the title Fixes RK4 time-stepper and the Diiffusion test module Fixes the RK4 time-stepper and the Diiffusion test module Dec 27, 2018
@navidcy navidcy mentioned this pull request Dec 27, 2018
@coveralls
Copy link

coveralls commented Dec 27, 2018

Coverage Status

Coverage increased (+1.5%) to 70.637% when pulling a6b21d5 on FixesDiffusionTestModule+RK4 into 7a929e3 on master.

@navidcy navidcy merged commit d9cf1db into master Dec 27, 2018
@navidcy navidcy deleted the FixesDiffusionTestModule+RK4 branch January 17, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants