Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.5-layer QG functionality #137

Closed
navidcy opened this issue Nov 18, 2020 · 7 comments · Fixed by #160
Closed

Add 1.5-layer QG functionality #137

navidcy opened this issue Nov 18, 2020 · 7 comments · Fixed by #160
Labels
🤥 enhancement New feature or request

Comments

@navidcy
Copy link
Member

navidcy commented Nov 18, 2020

It's easy to include a finite Rossby deformation radius in BarotropicQG module. I vote first to clear up BarotropicQG module as implied by #135 and then modify the BarotropicQG module to add such functionality.

pinging @liasiegelman as she's interested and could help us out here.

@navidcy navidcy added the 🤥 enhancement New feature or request label Nov 18, 2020
@liasiegelman
Copy link
Collaborator

sounds good to me. I will let you know as soon as my barotropicQG with kdef implemented in the streamfunction runs smoothly

@navidcy
Copy link
Member Author

navidcy commented Nov 28, 2020

@liasiegelman, v0.9.0 includes a cleaner BarotropicQG module. Feel free to make a PR modifying it to include finite Rossby radius of deformation. We can then work on it together if you like :)

Perhaps we should change the module's name since it won't be purely barotropic then? What about OneLayerQG?

cc @glwagner

@liasiegelman
Copy link
Collaborator

Thanks @navidcy, will do. What about equivalentbarotropicQG for the name?

@glwagner
Copy link
Member

OneLayer is probably better than Barotropic anyways! EquivalentBarotropicQG seems good too.

@navidcy
Copy link
Member Author

navidcy commented Dec 1, 2020

Does the name EquivalentBarotropicQG include the purely barotropic case k_deformation=0? If so then it's good name. Otherwise let's go with OneLayerQG or SingleLayerQG.

@liasiegelman
Copy link
Collaborator

ah yes then it's just barotropic so probably better to stick with your original suggestion.

@glwagner
Copy link
Member

glwagner commented Dec 1, 2020

"SingleLayer" might be a better complement to "Multilayer" (eg with "OneLayer" we might want "NLayer").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤥 enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants