Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor enhancements in Docs/Stochastic Forcing section #184

Merged
merged 6 commits into from
Jan 15, 2021

Conversation

navidcy
Copy link
Member

@navidcy navidcy commented Jan 10, 2021

  • Fixes warning/complaining of Docs for duplicate ref to TwoDNavierStokes.energy_work().
  • Adds definition for Brownian motion W_t.
  • Some code beautifications.

Screen Shot 2021-01-11 at 7 38 33 am

@navidcy navidcy changed the title Fixes warning/complaining of Docs for duplicate ref to TwoDNavierStokes.energy_work() Minor fixes in Docs/Stochastic Forcing Jan 10, 2021
@navidcy navidcy changed the title Minor fixes in Docs/Stochastic Forcing Minor enhancements in Docs/Stochastic Forcing section Jan 10, 2021
@glwagner
Copy link
Member

Do we use subscript notation for derivatives anywhere? Could confuse the definition of W_t, which is not a time-derivative.

@navidcy
Copy link
Member Author

navidcy commented Jan 13, 2021

Do we use subscript notation for derivatives anywhere? Could confuse the definition of W_t, which is not a time-derivative.

I don’t think we do use subscripts for derivatives...

@liasiegelman
Copy link
Collaborator

liasiegelman commented Jan 13, 2021

I believe W_t is the standard notation for a Wiener process. You could maybe add continuity as a property like : "4. Continuity. With probability 1, W_t is continuous in t" ? Although I admit, it's really a detail...

@navidcy
Copy link
Member Author

navidcy commented Jan 13, 2021 via email

@liasiegelman
Copy link
Collaborator

liasiegelman commented Jan 13, 2021 via email

@navidcy
Copy link
Member Author

navidcy commented Jan 15, 2021

so shall I merge?
feel free to critique the whole Stochastic Forcing section if you like ;)

@glwagner
Copy link
Member

so shall I merge?
feel free to critique the whole Stochastic Forcing section if you like ;)

That was the only "issue" I found after a quick scan. Merge!

@navidcy navidcy merged commit 46cfdaf into master Jan 15, 2021
@navidcy navidcy deleted the ncc/fix-docs-duplicate-ref branch January 15, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants